-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(events): create global event id enum #4053
feat(events): create global event id enum #4053
Conversation
a54a79c
to
1940176
Compare
23bb9c0
to
01a4fa6
Compare
01a4fa6
to
d7db4ce
Compare
b046e08
to
28bbed6
Compare
28bbed6
to
b047d9d
Compare
b047d9d
to
e6391a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
go.mod
Outdated
@@ -45,6 +45,8 @@ require ( | |||
sigs.k8s.io/controller-runtime v0.16.3 | |||
) | |||
|
|||
replace github.com/aquasecurity/tracee/api => github.com/rscampos/tracee/api v0.0.0-20240520202449-d199291ce929 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to split this pr into 2, go.mod enters api first, main go.mod follows it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API: #4085
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geyslan splited the PR into 2, if you don't mind to do the last review, tks again :)
pkg/server/grpc/tracee.go
Outdated
@@ -19,6 +19,574 @@ import ( | |||
"github.com/aquasecurity/tracee/types/trace" | |||
) | |||
|
|||
// EventTranslationTable - translate internal to external Event ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
// EventTranslationTable - translate internal to external Event ID | |
// EventTranslationTable translates internal to external protobuf Event Id |
e6391a2
to
bc0055c
Compare
- create an array for translation internal ID to external ID; - External syscall event starts at 1; - External common event starts at 1000; - External originated from user-space event start at 2000.
bc0055c
to
53d93ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - green in E2E tests (1553).
1. Explain what the PR does
fix #1098
53d93ea fix(tests): event ID translation
4806e8a feat(events): create global event id enum
4806e8a feat(events): create global event id enum
2. Explain how to test it
3. Other comments